Skip to content

fix: should copy public dir to environment's dist dir#4268

Merged
chenjiahan merged 6 commits intomainfrom
copy-public-dir
Dec 26, 2024
Merged

fix: should copy public dir to environment's dist dir#4268
chenjiahan merged 6 commits intomainfrom
copy-public-dir

Conversation

@9aoy
Copy link
Contributor

@9aoy 9aoy commented Dec 25, 2024 •
edited
Loading

Summary

  • Should copy publicDir to the environment distDir when multiple environments, except for nested dist directories.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Dec 25, 2024 •
edited
Loading

✅ Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit b416e90
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/676d1e5de574a600088cb2fb
😎 Deploy Preview https://deploy-preview-4268--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 69 (🔴 down 12 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2024 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
plugins ✅ success
rspress ✅ success
rslib ✅ success
examples ✅ success

@9aoy 9aoy requested a review from chenjiahan December 25, 2024 07:32
chenjiahan
chenjiahan reviewed Dec 26, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR can be split into two PRs. The node target related change is important and we should let users know.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2024 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
plugins ✅ success
rspress ✅ success
rslib ✅ success
examples ✅ success

@9aoy 9aoy requested a review from chenjiahan December 26, 2024 06:06
chenjiahan
chenjiahan reviewed Dec 26, 2024
View reviewed changes
chenjiahan
chenjiahan reviewed Dec 26, 2024
View reviewed changes
chenjiahan
chenjiahan reviewed Dec 26, 2024
View reviewed changes
9aoy and others added 2 commits December 26, 2024 17:13
@9aoy @chenjiahan
Update website/docs/zh/config/server/public-dir.mdx
5fc7f56 
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
@9aoy @chenjiahan
Update website/docs/en/config/server/public-dir.mdx
b416e90 
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
@chenjiahan chenjiahan merged commit b457159 into main Dec 26, 2024
9 checks passed
@chenjiahan chenjiahan deleted the copy-public-dir branch December 26, 2024 09:34
@chenjiahan chenjiahan changed the title fix: should copy publicDir to the environment distDir when multiple environments fix: should copy public dir to environment's dist dir Dec 26, 2024
@chenjiahan chenjiahan mentioned this pull request Dec 31, 2024
Merged
@chenjiahan chenjiahan mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

No one assigned

Labels

release: bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@9aoy @chenjiahan